-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: drop support for node 10 #8290
Conversation
e7fd33a
to
985cc8e
Compare
babf37a
to
7156118
Compare
9995660
to
82a8a1b
Compare
82a8a1b
to
737aceb
Compare
I have completed the prerequisites for the pull-request, namely updating |
I have checked the CIs and verified it by building it locally. It worked as expected.
|
the following commit drops `node v10` support from the framework: - updates the `engines` tag. - updates any documentation related to node version. - updates the CI to drop `node 10` builds. Signed-off-by: vince-fugnitto <[email protected]>
737aceb
to
d016579
Compare
I'll merge the changes later during the week if there are no objections. |
@vince-fugnitto please merge |
What it does
Fixes: #8184
The following pull-request drops support for Node v10 from the framework in favor of Node v12:
engines
tag (so the minimum and maximum node versions are respected when building).Prerequisites:
theia-apps
to drop support for node 10: repo: drop support for node 10 when building images theia-ide/theia-apps#391How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]