Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: drop support for node 10 #8290

Merged
merged 1 commit into from
Aug 21, 2020
Merged

repo: drop support for node 10 #8290

merged 1 commit into from
Aug 21, 2020

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Aug 3, 2020

What it does

Fixes: #8184

The following pull-request drops support for Node v10 from the framework in favor of Node v12:

  • updates the node engines tag (so the minimum and maximum node versions are respected when building).
  • updates any documentation related to the node version
  • updates the CI to drop the node v10 builds

Prerequisites:

How to test

  • verify that it is no longer possible to build with node 10
  • verify that the CI build for node 10 is successfully removed

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added documentation issues related to documentation dependencies pull requests that update a dependency file labels Aug 3, 2020
@vince-fugnitto vince-fugnitto self-assigned this Aug 3, 2020
@vince-fugnitto vince-fugnitto force-pushed the vf/drop-node-10 branch 3 times, most recently from e7fd33a to 985cc8e Compare August 3, 2020 14:46
doc/Developing.md Outdated Show resolved Hide resolved
@vince-fugnitto vince-fugnitto force-pushed the vf/drop-node-10 branch 3 times, most recently from babf37a to 7156118 Compare August 3, 2020 16:42
CHANGELOG.md Outdated Show resolved Hide resolved
@vince-fugnitto vince-fugnitto force-pushed the vf/drop-node-10 branch 3 times, most recently from 9995660 to 82a8a1b Compare August 6, 2020 19:03
@vince-fugnitto vince-fugnitto marked this pull request as ready for review August 14, 2020 13:18
@vince-fugnitto
Copy link
Member Author

I have completed the prerequisites for the pull-request, namely updating theia-apps to cleanup the images following the deprecations and dropping node 10 support in preparation for the changes proposed in this pull-request.

@kittaakos
Copy link
Contributor

I have checked the CIs and verified it by building it locally. It worked as expected.

akos.kitta@Akoss-MacBook-Pro theia % nvm use 10
Now using node v10.16.3 (npm v6.9.0)
akos.kitta@Akoss-MacBook-Pro theia % yarn
yarn install v1.22.4
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | x64
gyp http GET https://nodejs.org/download/release/v10.16.3/node-v10.16.3-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v10.16.3/node-v10.16.3-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v10.16.3/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v10.16.3/SHASUMS256.txt
10.16.3
gyp info ok 
[1/5] 🔍  Validating package.json...
error @theia/[email protected]: The engine "node" is incompatible with this module. Expected version ">=12.14.1 <13". Got "10.16.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
akos.kitta@Akoss-MacBook-Pro theia % nvm use 12
Now using node v12.14.1 (npm v6.13.4)
akos.kitta@Akoss-MacBook-Pro theia % yarn
yarn install v1.22.4
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | x64
gyp http GET https://nodejs.org/download/release/v12.14.1/node-v12.14.1-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v12.14.1/node-v12.14.1-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v12.14.1/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v12.14.1/SHASUMS256.txt
12.14.1
gyp info ok 
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
$ node scripts/post-install.js
@theia/electron last logs:
(Thu, 13 Aug 2020 14:56:52 GMT) info: Found cached ffmpeg library.
(Thu, 13 Aug 2020 14:56:52 GMT) info: Hashes are equal, not replacing the ffmpeg library.
(Thu, 13 Aug 2020 14:56:52 GMT) info: "/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Libraries/libffmpeg.dylib" does not contain proprietary codecs (16 found).
$ yarn prepare:travis && yarn prepare:references && yarn prepare:build && yarn prepare:hoisting && yarn download:plugins
yarn run v1.22.4
$ node scripts/prepare-travis.js

[...]

- vscode-builtin-yaml: already downloaded - skipping
- vscode-editorconfig: already downloaded - skipping
- vscode-eslint: already downloaded - skipping
- vscode-references-view: already downloaded - skipping
✨  Done in 0.48s.
✨  Done in 128.91s.

the following commit drops `node v10` support from the framework:
- updates the `engines` tag.
- updates any documentation related to node version.
- updates the CI to drop `node 10` builds.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

I'll merge the changes later during the week if there are no objections.
Thank you for the review @kittaakos!

@akosyakov
Copy link
Member

@vince-fugnitto please merge

@vince-fugnitto vince-fugnitto merged commit b10fec5 into master Aug 21, 2020
@vince-fugnitto vince-fugnitto deleted the vf/drop-node-10 branch August 21, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dependency][core] Drop Node.js 10.x support
4 participants