Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preferences] module name changed (preferences-contribution) #8237

Conversation

minyoungyang
Copy link
Contributor

@minyoungyang minyoungyang commented Jul 27, 2020

Fixes #8203

What it does

  • Renamed the module from preference-contribution to preferences-contribution.

How to test

  • Execute commands in PreferencesContribution

Review checklist

Reminder for reviewers

Signed-off-by: Min-young Yang [email protected]

Fixes: eclipse-theia#8203

This PR renames module from 'preference-contribution' to 'preferences-contribution'.

Signed-off-by: Min-young Yang <[email protected]>
@minyoungyang minyoungyang marked this pull request as ready for review July 27, 2020 07:29
@vince-fugnitto vince-fugnitto added preferences issues related to preferences quality issues related to code and application quality labels Jul 27, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution 👍

@vince-fugnitto vince-fugnitto merged commit 1867d15 into eclipse-theia:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences quality issues related to code and application quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quality][preferences] PreferencesContribution does not follow the module name recommendations
2 participants