navigator: fix explorer 'open' command #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
vince-fugnitto
force-pushed
the
vf/nav-open
branch
2 times, most recently
from
a56cd77 to
8f1f00f
Compare
akosyakov
approved these changes
Jul 28, 2020
the following commit fixes the `open` command for the navigator to only display the command for file nodes and not directories (since directories cannot be opened). Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/nav-open
branch
from
8f1f00f to
a0bbf39
Compare
Anasshahidd21
approved these changes
Aug 1, 2020
|
@vince-fugnitto merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #1308
Fixes: #2675
The following pull-request updates the
opencommand present in the explorer context-menu to only be applicable for file resources and not directories (as directories cannot be opened). The context-menu is only visible and enabled if in the list ofselectedNodesa file is present, and will only attempt to open files when executed.How to test
The test-cases are performed using the explorer context-menu:
openis available when right-clicking a file node, executing the command opens the editoropenis available when right-clicking multiple selected file nodes, executing the command opens all the editorsopenis not available when right-clicking a directory nodeopenis not available when right-clicking multiple selected directory nodesopenis available when selecting both a file node and directory node, executing the command opens only the editor(s) and no error is thrownReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]