Sort for quick open entries respecting highlight information #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 tasks
RomanNikitenko
changed the title
akosyakov
added
monaco
akosyakov
approved these changes
Jul 28, 2020
RomanNikitenko
force-pushed
the
compareQuickOpenEntries
branch
from
f8b69c3 to
55b1d03
Compare
11 tasks
13 tasks
18 tasks
Signed-off-by: Roman Nikitenko <[email protected]>
RomanNikitenko
force-pushed
the
compareQuickOpenEntries
branch
from
55b1d03 to
17ecd38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Provide ability to compare quick open entries
Closes #7899
The PR contains copied functions from VS Code, please see my comment in the issue #7899 (comment)
I'll provide the corresponding CQ if the changes look good
Update: the reference to the CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22443
How to test
The bug is actual for
masterbranch at using theQuickOpenServicewithtruevalue forfuzzySortproperty.So, for testing I used
F1 --> Variable:List Allsince it hastruevalue forfuzzySortproperty herePlease see actual and expected behavior in the issue description #7899
Review checklist
Reminder for reviewers
Signed-off-by: Roman Nikitenko [email protected]