editor: save dirty editors when toggling auto-save on

[vince-fugnitto]

What it does

The following pull-request updates the toggleAutoSave method to trigger a saveAll (for all dirty content), when the auto-save preference value is turned on. This behavior of saving dirty content across multiple editors is consistent with vscode and improves the user-experience.

How to test

1. start the application with a workspace present
2. ensure that auto-save is off
3. make dirty (unsaved) changes in multiple files
4. update the auto-save by enabling it in the file menu
5. the dirty editors should be saved

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[Anasshahidd21]

Looks well for me.

1. Tested with setting the preference on the autoSave to on.
2. Tested with the autoSave toggle in the file-menu.

OS: Windows.

[lmcbout]

Tested on UBUNTU 18.04 and Chrome

• Set the File-> Auto Save to "OFF"
• I opened the file setting.json from the workspace
• modify a few files with auto-save "OFF"
• Open menu, then select "Auto Save"
  --> Since the file setting.json was in the editor, it puts the auto-save:"on" but did not save the preference file setting, so the other file did not get saved either.
  This is a corner case here, otherwise, turning the "Auto Save" to "ON" works fine with any other files.

[vince-fugnitto]

@lmcbout do you mind re-reviewing the pull-request?

This is a corner case here, otherwise, turning the "Auto Save" to "ON" works fine with any other files.

I do not believe the comment you had about the settings.json is a bug.
We trigger a saveAll based on the preference changed event and if the settings.json is simply modified (off to on) this does not trigger an event, only explicitly saving the document will. We should not try to interpret that the user has unmodified changes for autoSave and trigger a save in my opinion.

[lmcbout]

Tested with commit 42a09db
On Ubuntu 18.04 and Chrome
If the file "setting.json" is not open in the editor, it works fine. OK
If the file "settings.json" is OPEN in the editor and I set "AutoSave" = "ON"
Then it does not autoSave

[vince-fugnitto]

@lmcbout the bug about the toggle command causing dirty changes to the settings.json is on master as well.

• corresponding issue: Preference changes not registered when settings.json open in editor. #7721

[lmcbout]

Thanks @vince-fugnitto
LGTM

[vince-fugnitto]

I'll merge tomorrow if there are no objections :)