[Fix] onDidEndTaskProcess event is not fired for plugins when task ends

[tal-sapan]

Signed-off-by: Tal Sapan [email protected]

What it does

According to VSCode documentation, when a task ends, the events onDidEndTask and onDidEndTaskProcess events are fired. onDidEndTaskProcess is only fired for tasks that execute an underlying process.
However, the onDidEndTaskProcess event is not fired in Theia.
This PR fixes this issue by firing the event for all tasks of type ProcessTask.

Note that the order of firing the two events is important: onDidEndTaskProcess must be fired first because when onDidEndTask is fired, the task execution is removed from the list of currently running task executions in $onDidEndTask and not recognized in $onDidEndTaskProcess:

theia/packages/plugin-ext/src/plugin/tasks/tasks.ts

Line 78 in bc16fc1

this.executions.delete(id);

How to test

1. Run this plugin in theia: https://github.com/tal-sapan/logtaskendprocessevent (or use the vsix I will attach in a comment).
2. Run any shell or process task, for example:

{
    "label": "Hello World",
    "type": "shell",
    "command": "echo hello"
}

3. Open the LogTaskEndProcessEvent output channel and see in the output:
   Task process ended with exit code 0: Hello World

Without this PR nothing is printed to the channel output.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[tal-sapan]

vsix file of the plugin used for testing (change the file extension to .vsix instead of .vsix.zip):
logtaskendprocessevent-0.0.1.vsix.zip

[kittaakos]

if (task instanceof ProcessTask) should be enough.

[tal-sapan]

I will change it.
However, it is the same as in fireTaskCreatedEvent method. Should I change it there too?

[RomanNikitenko]

The changes look good for me.
Tested for a shell and npm tasks using provided extension and can see the log:
Task process ended with exit code 0: test task

[tal-sapan]

Hi @RomanNikitenko,

Thanks for the review.
Would it be possible to merge the PR? Or should another person review it first?

Thanks,
Tal

[RomanNikitenko]

@tal-sapan
Thank you for the fix!

I'm going to merge the PR tonight for case if someone wants to review/test it today.