Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monaco] remove unused dependencies #8109

Merged
merged 1 commit into from
Jun 29, 2020
Merged

[monaco] remove unused dependencies #8109

merged 1 commit into from
Jun 29, 2020

Conversation

akosyakov
Copy link
Member

What it does

We don't use monaco language services for css and html anymore, but VS Code extensions.

How to test

  • Check that language smartness is still there for css and html.

Review checklist

Reminder for reviewers

@akosyakov akosyakov added dependencies pull requests that update a dependency file monaco issues related to monaco labels Jun 29, 2020
kittaakos
kittaakos approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you! I noticed last week that they're still there. 👍

vince-fugnitto
vince-fugnitto approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that intelligence still works correctly for html and css files.

@akosyakov akosyakov merged commit e4d87c7 into master Jun 29, 2020
@akosyakov akosyakov deleted the ak/remove_unused_monaco_deps branch June 29, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
dependencies pull requests that update a dependency file monaco issues related to monaco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akosyakov @kittaakos @vince-fugnitto