cli: update 'download:plugins' script #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #8053 The following commit updates the `download:plugins` script to report when the mandatory `theiaPlugins` property is missing from the `package.json` resulting in no plugins being downloaded. Signed-off-by: vince-fugnitto <[email protected]>
lmcbout
approved these changes
Jun 19, 2020
There was a problem hiding this comment.
Works as expected
Error message is fine
Thanks @vince-fugnitto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8053
The following pull-request updates the
download:pluginsscript to report a message when the mandatorytheiaPluginsproperty is missing from thepackage.jsonultimately resulting inno plugins being downloaded.
How to test
yarn download:plugins(plugins should be successfully downloaded)pluginsdirectory (rm -rf plugins/)theiaPluginstotheiaPluginsTest(in thepackage.json)yarn download:plugins(the error message of the mandatory field is logged)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]