fix isInSync check to be with latest resource stat #8044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves race condition that happens when there are several consecutive calls to saveContentChanges. since before this fix, version was passed to isInSync before asynchronously calling getFileStat there were times when it was old on the sync check but current on this.version. then onDidChangeContentsEmitter.fire was called wrongly Signed-off-by: Amiram Wingarten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amiram Wingarten [email protected]
What it does
Solves race condition that happens when there are several consecutive calls to saveContentChanges.
Since before this fix, version was passed to isInSync before asynchronously calling getFileStat there were times when it was old on the sync check but current on this.version.
then onDidChangeContentsEmitter.fire was called wrongly.
Also there is no reason to pass a method with this.version as it can get it from the instance.
How to test
It's hard to reproduce the issue that was solved. Basically updating the resource content several times could cause sphoradic firing of the above event.
Review checklist
Reminder for reviewers