Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[problems] Implemented clear-all in problems view. #8002

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

Anasshahidd21
Copy link
Contributor

@Anasshahidd21 Anasshahidd21 commented Jun 12, 2020

What it does

Fixes: #7979

Added a Clear-All toolbar item, which clears all the existing problem
markers

Tested the icon doesn't leak to other views such as:

  1. Terminal
  2. Output Channel
  3. Search in Workspace
  4. Extensions.

Signed-off-by: Anas Shahid [email protected]

How to test

  1. create multiple json files, with lorem ispum, it will generate problem markers
  2. Click on the icon on the toolbar to clear all the markers.
  3. Close the file and re-open it to see if the markers are present.
  4. Test to see if the icon is leaking to any other view.(like siw)

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the output issues related to the output label Jun 12, 2020
@akosyakov akosyakov requested a review from kittaakos June 13, 2020 10:03
@akosyakov
Copy link
Member

Please make sure that toolbar item does not leak to other views, i.e. isEnabled and isVisible are respecting the current widget. (if it is not the case yet)

@Anasshahidd21 Anasshahidd21 force-pushed the clearAllProblems branch 2 times, most recently from b0e0658 to 4b75418 Compare June 15, 2020 15:44
Fixes: eclipse-theia#7979

Added a `Clear-All` toolbar item, which clears all the existing problem
markers

Signed-off-by: Anas Shahid <[email protected]>
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it in Gitpod; it worked as expected. Thank you, @Anasshahidd21 👍

Note: When I execute the Reset Workbench Layout command, the Problems view is opened, hence the command is enabled, but the bottom panel is toggled, so one cannot eventually see the Problems view. Strange UX; this has to be addressed in a separate issue if we want to change it.

@kittaakos kittaakos merged commit c1d11d0 into eclipse-theia:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output issues related to the output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[problems] Implement Clear All action for the Problems view.
4 participants