-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat #7892: support vsc ext create pseudo terminal #7925
feat #7892: support vsc ext create pseudo terminal #7925
Conversation
It would be good to have something more concrete steps for reviewers.
|
I have tested my changes with the extension. Maybe i should remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks quite good. I hope it works as good too, someone has to test it.
@datou0412 Could you add |
I have fixed all conversation issues, re-review is welcomed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I'll let Anton review the widget-api/storage aspect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with the sample vscode extension and it behaves in the same way as in VS Code
Please get rid of commits fixing issues introduced by the PR. One commit will be enough. Please see: https://github.com/eclipse-theia/theia/blob/master/doc/pull-requests.md#checklist-commit-history
Signed-off-by: 二凢 <[email protected]>
Signed-off-by: 二凢 [email protected]
What it does
Support API
vscode.window.createTerminal
with option ExtensionTerminalOptions_pseudoTerminals
in memoryTerminalServiceMainImpl
listen to terminal widget events and call _pseudoTerminals&widget methods through proxyTerminalWidgetImpl
fire events and expose methods.PseudoPty
in backend.Plugin Process
<--proxy-->TerminalServiceMain
<--Events&Methods-->TerminalWidget
<--proxy-->Shell Process
How to test
Install any extension which use the api
vscode.window.createTerminal
with optionExtensionTerminalOptions
vsce
and move the .vsix file toplugins
folderJust input anything
Resize your window
Review checklist
Reminder for reviewers