plugin-ext: attach security cookie to webviews

[paul-marechal]

When on Electron, we use a cookie to tell if an http client can use the
backend services. Cookies are bound to domains to which requests will be
made, and also subdomains in certain situations. Because we are using
localhost the cookie cannot be shared across subdomains. This commit
works around this limitation by passing the security token from
electron-main process to the renderer-process via a global variable,
and the token is then set inside a cookie for each new webview endpoint
created by the plugin system in the frontend.

How to test

Install and use https://github.com/vince-fugnitto/webview-example/releases/download/1.0.0/cat-coding-0.0.1.vsix, it should work on Electron.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

The localhost limitation regarding setting cookies for subdomains was really not intuitive... But the issue boils down to some domain property that must be set in the cookie, but that also must be at least two parts: something like a.b which is not the case for the localhost domain (only one part).

[vince-fugnitto]

I verified that webviews now successfully work on electron 🍾

[paul-marechal]

@benoitf @akosyakov refactored the widget factory into new inversify modules.

[akosyakov]

Please merge if it works

[akosyakov]

Please look at comments before merging. I don’t think entry points designed well, they cannot be reused and separate code which can only work together. I think they should be removed there is no real motivation for reuse right now.

[paul-marechal]

@benoitf is this change to the inversify containers ok with you? cc @akosyakov

[akosyakov]

You can add frontendElectron in another entry point to rebind something from frontend of first entry point:

"theiaExtensions": [
    {
      "backend": "lib/plugin-ext-backend-module",
      "backendElectron": "lib/plugin-ext-backend-electron-module",
      "frontend": "lib/plugin-ext-frontend-module"
    },
    {
      "frontendElectron": "lib/plugin-ext-frontend-electron-module"
    }
  ]

It would be the minimal change.

[marcdumais-work]

Let me give this a quick test

[marcdumais-work]

It works! 👍

There are notifications that appear every few seconds. The message is not very specific :)

[paul-marechal]

Will wait on CI to be green again and merge then.

[marcdumais-work]

@marechal-p did you see the notifications popping-up when you tested?

[paul-marechal]

@marcdumais-work didn't notice that on your screen it is missing the icons for some reason. On windows I have them displayed correctly. The notifications are part of the cat coding VS Code extension.

[marcdumais-work]

I see it on the browser version as well, so prob unrelated to this PR

[marcdumais-work]

@marcdumais-work didn't notice that on your screen it is missing the icons for some reason. On windows I have them displayed correctly. The notifications are part of the cat coding VS Code extension.

Strange. You're right, browser version has them:

[paul-marechal]

Opened a followup issue based on your issue with icons @marcdumais-work