respect keybinding scope and registration order during evaluation

[akosyakov]

What it does

• fix Ctrl-c (terminate) not working in Terminals #7836: see explanation Ctrl-c (terminate) not working in Terminals #7836 (comment)
• (performance) Also match only first keybinding on keydown, don't traverse over all keybindings.

How to test

• Monaco: see tests from register Monaco keybindings in reverse order #6170
• Theia extension: see Ctrl-c (terminate) not working in Terminals #7836 on linux/windows
• VS Code extension: see Fixes for Vscode emacs extension #6625 (comment)
  • install emacs extension
  • open some editor
  • use ctrl+x ctrl+l on linux/windows it should not cut, but wait for ctrl+l

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@tsmaeder @RomanNikitenko @502647092 Could you check please whether it resolves issues mentioned in #5749, #7833 and #7836?

I'm testing too, but I'm on Mac.

[RomanNikitenko]

I tested these changes on Fedora 31
The PR fixes use cases which I described in #7833

[tsmaeder]

Ctrl-c seems to work on Windows FF and Chromium.

[tsmaeder]

I've found a different problem, though: every once in a while (seems more frequent on Firefox), the following task:

{
            "type": "shell",
            "command": "timeout /T 10",
            "label": "wait",
            "problemMatcher":"$eslint-compact"
        }

Seems to terminate with exit code 0 immediately instead of waiting 10 seconds.
@akosyakov is your branch based on latest master?

[akosyakov]

@akosyakov is your branch based on latest master?

yes, i don't think it is related to keybindings handling

[akosyakov]

I'm:

• adding more regression tests for the monaco extension
• adding more regression tests for the terminal extensions
• trying to resurrect some fixes from [keybindings] Aligned keybindings with VSCode #5326 from @JPinkney (code was changed in the meantime unfortunately)
  • registered collided keybindings with higher priority, don't fail as before
    • there is not really a way to detect whether keybindings are collided without evaluating them in some context
  • filter out removed keybindings during evaluation

[tsmaeder]

I've built master after deleting all node_modules folders, and I can't observer the "early exit"-behaviour anymore. Not sure what did it, though.

[akosyakov]

@502647092 I would love to have your feedback whether it resolves issues in #5749?

[akosyakov]

@RomanNikitenko could you double test it please? I have changed a lot since you looked at it. Thank you 🙏

[RomanNikitenko]

@akosyakov
Tested on Fedora terminate process in terminal and terminate a task after your update - it works well for me!

[akosyakov]

@RomanNikitenko ok, thanks, I will merge tomorrow morning if there won't be any other feedback

[RomanNikitenko]

Also I tried for emacs:

• select all - ctrl-x h
• quick open for a file - ctrl-x b

[502647092]

@akosyakov It looks like it can work