-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vscode] support new CompletionItem.range shape #7820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing a quick fix to the issue 👍
There seems to be CI errors regarding completionItems
in the metrics extension:
Also don't send: - duplicate ranges on provide completions - entire completion back and forth on resolve completion Signed-off-by: Anton Kosyakov <[email protected]>
8afa0b6
to
bf4e09b
Compare
@vince-fugnitto should be fixed now |
@akosyakov The PR does not compile. See the errors reported: 3- packages/plugin-metrics/src/browser/plugin-metrics-frontend-module.ts:31:34 - error TS2345: Argument of type 'typeof LanguagesMainPluginMetrics' is not assignable to parameter of type 'new (...args: any[]) => LanguagesMainImpl'. |
@lmcbout please fetch new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on UBUNTU 18.04
Looks good, no more loops reported on the console about the "Invalid Completion Item"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that completion items are now properly populated (ex: when editing a typescript file).
What it does
Also don't send:
How to test
Review checklist
Reminder for reviewers