Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preferences ui tab styling #7793

Conversation

kenneth-marut-work
Copy link
Contributor

@kenneth-marut-work kenneth-marut-work commented May 11, 2020

What it does

Fixes #7768

This PR addresses issue #7768 to only show the preferences tabbar shadow when the editor is scrolled, and also provides some additional styling improvements to the preferences tab bar to be more in-line with VSCode including:

  • Moving tab highlight to bottom of tab
  • Adding a dividing line below tab bar
  • Removing residual 'focus' behavior when the 'folders' tab is selected using a mouse click in a multiroot workspace
    tab-shadow2
    tab-shadow-light

How to test

  • Pull changes and open preferences UI in a multi root workspace
  • Browse preferences and observe drop shadow behavior tab bar styling improvements when scrolling

Review checklist

Reminder for reviewers

@kenneth-marut-work kenneth-marut-work force-pushed the feature/preferences-ui-tab-styling branch 2 times, most recently from 1cfa453 to e5f8d3e Compare May 12, 2020 15:16
@kenneth-marut-work
Copy link
Contributor Author

Known issues:
If preference item in preference tree is selected and preferences UI is closed and reopened, editor scroll location is not preserved and is automatically scrolled to top while tree state is preserved (this will cause the shadow to show even though the editor is scrolled to top). This is related to #7746

@kenneth-marut-work kenneth-marut-work marked this pull request as ready for review May 12, 2020 16:11
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenneth-marut-work do you mind rebasing and squashing your commits before we proceed with the review?

@vince-fugnitto vince-fugnitto added preferences issues related to preferences ui/ux issues related to user interface / user experience labels May 12, 2020
@kenneth-marut-work kenneth-marut-work force-pushed the feature/preferences-ui-tab-styling branch from e5f8d3e to 509d8ce Compare May 12, 2020 17:43
@kenneth-marut-work
Copy link
Contributor Author

@vince-fugnitto
My mistake! Should be good to go now

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes they look very nice 👍
I see that:

  • active tab is properly highlighted
  • active tab is now highlighted at the bottom (hover works nicely as well)
  • the shadow-border is correctly visible only when scrolling
  • verified using multiple themes (light + dark)

@vince-fugnitto
Copy link
Member

Merging! Thank you for your contribution @kenneth-marut-work 👍

@vince-fugnitto vince-fugnitto merged commit 87c7705 into eclipse-theia:master May 14, 2020
@kenneth-marut-work
Copy link
Contributor Author

@vince-fugnitto you're welcome, thanks for the review + merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preferences issues related to preferences ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preferences: hide shadow if preferences are not scrolled
2 participants