preferences: fix regex incompatible with Firefox #7774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox doesn't handle lookahead/lookbehind patterns in regexes, leading to Theia applications not starting when ran inside Firefox. This commit replaces the problematic regex with a method that produces the same result. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
added
bug
vince-fugnitto
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox doesn't handle lookahead/lookbehind patterns in regexes, leading
to Theia applications not starting when ran inside Firefox.
This commit replaces the problematic regex with a method that produces
the same result.
Fixes: #7771
How to test
Theia's browser example application should now work in Firefox.
Review checklist
Reminder for reviewers