Update uuid to v8 #7749
Update uuid to v8 #7749
Conversation
Signed-off-by: Reece Dunham <[email protected]>
|
As long as electron-builder isn't using the default export (removed in v8), it will be fine. |
electron-builder does not use v8, it bundles all node modules and picks only one version for Electron. We are talking about breaking this line: https://github.com/eclipse-theia/theia/pull/7749/files#diff-e6697ec7c0f7ddbbfd9e8365baacf132R133 if electron-builder pick s v3 since it used by request and trash packages. |
|
What would be the real benefits of this PR for adopters and end users besides that build process can be broken? |
|
Actually, even if it does pick v3 then the changed code you linked will still work. The changes for v8 is just removing the default export, so if apps don't use it, it will still work. |
| @@ -130,7 +130,7 @@ if (process.env.LC_ALL) { | |||
| } | |||
| process.env.LC_NUMERIC = 'C'; | |||
|
|
|||
| const uuid = require('uuid'); | |||
There was a problem hiding this comment.
I don't think you need to change this, am I missing something?
There was a problem hiding this comment.
UUID no longer has a default export as of v7 or v8
There was a problem hiding this comment.
This is not making use of the default export, this is binding the exports object to the uuid name.
|
@marechal-p please merge when you think it is good |
Signed-off-by: Reece Dunham [email protected]
What it does
Updates
uuidfrom v3 to v8. In comparison, v8 uses more modern Javascript and cleaner code, so it should be easier to work with.It also updates the types to the latest version.
I have confirmed there are no license changes, as outlined in this wiki page.
How to test
This contains no functional breaking changes. In application-manager, I had to fix the fact that a default export is no longer provided, but other than that it should have no visible changes. I also ran the Jest tests and ESLint, which both reported no errors.
Review checklist