outline: fix keybinding collision on linux #7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes a keybinding collision between toggling the outline view, and performing the operation 'format document'. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
outline
|
@sunix Could you check please that it works for you? I am not on Linux unfortunately. I will check whether format document and outline still work on Mac. |
I managed to test on both mac and linux, but unfortunately I don't have a windows machine. |
akosyakov
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
it works for me on mac, but it would be good if someone double check on linux besides @vince-fugnitto
Vince, can you ping your teammates?
@lmcbout @Anasshahidd21 do you mind trying the pull-request on Linux? |
|
@vince-fugnitto I will test |
lmcbout
approved these changes
Apr 29, 2020
Anasshahidd21
approved these changes
Apr 29, 2020
|
Tested on RHEL8 + Chrome, works great :) |
RomanNikitenko
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6423
The commit fixes a keybinding collision on Linux between:
format documentDue to priority, the
format documentwill take precedence over being able to toggle the outline view based on the decision taken in the issue: #6423 (comment)How to test
Linux
(it should successfully format the document instead of toggling the outline view)
Other OS
(should work correctly)
(should successfully open the outline-view)
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]