cli: replace request package #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
enhancement
`requestretry` looks very bogus and forced us to put buffering in place, which slowed down the whole script drastically. This commit replaces `requestretry` by `node-fetch` which better handles node streams. Signed-off-by: Paul Maréchal <[email protected]>
paul-marechal
force-pushed
the
mp/download-plugins
branch
from
1b009d5 to
6d58c5b
Compare
|
@marechal-p . I added some java plugins, tested and it is fast for redhat-java as well One thing the vscode-builtin-node-debug is still failing x vscode-builtin-node-debug: failed to download with: 404 Not Found
StaticticsDone in 12.88s. For sure, it is better than 3-8 minutes to download:plugins |
vince-fugnitto
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
I did the following checks:
- the new dependencies are license certified:
- the script correctly works and no longer takes a long time when including
vscode-redhat-java:
yarn run v1.22.4
$ theia download:plugins
--- downloading plugins ---
+ vscode-builtin-bat: downloaded successfully
+ vscode-builtin-clojure: downloaded successfully
+ vscode-builtin-css: downloaded successfully
+ vscode-builtin-docker: downloaded successfully
+ vscode-builtin-csharp: downloaded successfully
+ vscode-builtin-coffeescript: downloaded successfully
+ vscode-builtin-handlebars: downloaded successfully
+ vscode-builtin-go: downloaded successfully
+ vscode-builtin-configuration-editing: downloaded successfully
+ vscode-builtin-gulp: downloaded successfully
+ vscode-builtin-debug-auto-launch: downloaded successfully
+ vscode-builtin-cpp: downloaded successfully
+ vscode-builtin-hlsl: downloaded successfully
+ vscode-builtin-grunt: downloaded successfully
+ vscode-builtin-fsharp: downloaded successfully
+ vscode-builtin-json: downloaded successfully
+ vscode-builtin-log: downloaded successfully
+ vscode-builtin-jake: downloaded successfully
+ vscode-builtin-groovy: downloaded successfully
+ vscode-builtin-javascript: downloaded successfully
+ vscode-builtin-ini: downloaded successfully
+ vscode-builtin-html: downloaded successfully
+ vscode-builtin-make: downloaded successfully
x vscode-builtin-node-debug: failed to download with: 404 Not Found
+ vscode-builtin-java: downloaded successfully
+ vscode-builtin-lua: downloaded successfully
+ vscode-builtin-pug: downloaded successfully
+ vscode-builtin-less: downloaded successfully
+ vscode-builtin-theme-tomorrow-night-blue: downloaded successfully
+ vscode-builtin-markdown: downloaded successfully
+ vscode-builtin-perl: downloaded successfully
+ vscode-builtin-powershell: downloaded successfully
+ vscode-builtin-vb: downloaded successfully
+ vscode-builtin-razor: downloaded successfully
+ vscode-builtin-xml: downloaded successfully
+ vscode-builtin-ruby: downloaded successfully
+ vscode-builtin-rust: downloaded successfully
+ vscode-builtin-python: downloaded successfully
+ vscode-builtin-theme-kimbie-dark: downloaded successfully
+ vscode-builtin-shaderlab: downloaded successfully
+ vscode-builtin-r: downloaded successfully
+ vscode-builtin-shellscript: downloaded successfully
+ vscode-builtin-swift: downloaded successfully
+ vscode-builtin-theme-red: downloaded successfully
+ vscode-builtin-sql: downloaded successfully
+ vscode-builtin-scss: downloaded successfully
+ vscode-builtin-objective-c: downloaded successfully
+ vscode-builtin-theme-monokai-dimmed: downloaded successfully
+ vscode-builtin-theme-defaults: downloaded successfully
+ vscode-editorconfig: downloaded successfully
+ vscode-builtin-theme-monokai: downloaded successfully
+ vscode-builtin-theme-abyss: downloaded successfully
+ vscode-builtin-typescript: downloaded successfully
+ vscode-builtin-theme-quietlight: downloaded successfully
+ vscode-builtin-icon-theme-seti: downloaded successfully
+ vscode-builtin-theme-solarized-dark: downloaded successfully
+ vscode-builtin-yaml: downloaded successfully
+ vscode-builtin-merge-conflict: downloaded successfully
+ vscode-eslint: downloaded successfully
+ vscode-builtin-node-debug2: downloaded successfully
+ vscode-builtin-npm: downloaded successfully
+ vscode-builtin-emmet: downloaded successfully
+ vscode-references-view: downloaded successfully
+ vscode-builtin-markdown-language-features: downloaded successfully
+ vscode-maven: downloaded successfully
+ vscode-builtin-typescript-language-features: downloaded successfully
+ vscode-redhat: downloaded successfully
✨ Done in 6.06s.
I know there is an issue, but I also asked during the scrum if this issue would be fixed and the answer was : YES. This is why I brought it here. |
lmcbout
approved these changes
Apr 27, 2020
|
@lmcbout it used to crash the download script, thought you were talking about this issue. Will remove that plugin from our examples, since the package hosted on openvsx is bogus. See #7488 (comment) |
@marechal-p instead of removing it, you can reference the one from GitHub releases which is what the docker images are currently using: |
|
I would have preffered not even caring about this plugin tbh. This is just for the example applications, and is a legacy plugin. Unrelated, not touching it. |
paul-marechal
force-pushed
the
mp/download-plugins
branch
from
cea60ba to
6d58c5b
Compare
|
ci failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestretrylooks very bogus and forced us to put buffering in place,which slowed down the whole script drastically.
This commit replaces
requestretrybynode-fetchwhich better handlesnode streams.
How to test
See #7662 (comment)
Review checklist
Reminder for reviewers