Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7619: don't wrap menu action args into another array #7622

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

akosyakov
Copy link
Member

What it does

How to test

  • integration tests should be green
  • test that context menus are properly rendered in different places, i.e. toolbars for view container, views, editors and so on

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the menus issues related to the menu label Apr 20, 2020
@akosyakov akosyakov requested a review from AlexTugarev April 20, 2020 13:21
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the more ('...') context-menu on both the browser and electron targets and it works like before. I was able to successfully render the context-menu, and also trigger commands.

The integration tests are also successful 👍

Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Change LGTM as well!
Verified that ... menus do work properly now.

@akosyakov akosyakov merged commit 6d582d3 into master Apr 20, 2020
@akosyakov akosyakov deleted the akosyakov/more-command-in-view-7619 branch April 20, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
menus issues related to the menu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more command (...) in view containers does not work anymore
3 participants