plugin-ext: late textmate grammar activation

[paul-marechal]

There is a race condition when the layout is restored: if an editor was
opened, it will be restored and wait for some language activation event.
The issue with this was first seen with the builtin cpp extension: two
cpp grammars are contributed, but the first one is not the right one to
use on a cpp file. When an editor opened, the first bogus grammar is
loaded and activated, triggering bogus coloration.

This commit ensures that all grammars are more correctly contributed
before activating anything in the next event-loop tick.

Signed-off-by: Paul Maréchal [email protected]

Fixes eclipse-theia/theia-cpp-extensions#100

How to test

See eclipse-theia/theia-cpp-extensions#100, the coloration should not be bogus anymore.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[marcdumais-work]

Setup:

I did a quick sanity check on this PR, using Gitpod, and the following content saved as a.h in the workspace:

/* > Description *********************************************************************/
/**
 * sdads das asd asd asdasdasdasedasdsdas  dsa asd asd sd asdasd 
 * as dasd sd ad sad sad asd sad sad asd asdasdasdasdasdasdsadasddas
 *
 *****************************************************************************/
 /**
  * @file asdasasdasdasdasdasd.h
  * @brief
  * @see
  *
 *****************************************************************************/

/*>a************/
#ifndef asdasdasdasdasdasd
#define asdasdasdasdasdasd
#endif

There is another bug, related to the cpp grammar that's used in the example app: builtin [email protected]. So I removed the entry for this builtin from root package.json and removed the extension from ./plugins:

# stop test instance
rm -rf plugins/vscode-builtin-cpp/
# restart test instance
yarn --cwd examples/browser start ../.. --hostname=0.0.0.0

Then I installed the latest cpp built-in using the extensions view.

Test:

Without this fix, I only have to reload the application with editor containing a.h opened, and upon reload the syntax coloring is broken in the comments. With this fix, the coloring is still good after a few reloads! So it looks promising!

[akosyakov]

code-wise it makes sense, i have not tested, please make sure that it does not introduce regressions for previous changes

• use blame to identify commits
• from commits look at PRs
• run tests from How to test sections on such PRs

[paul-marechal]

@akosyakov thanks, I tried the instructions from #6966 and did not notice any regression.