support presentation.echo in task config #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added Paul as the reviewer because this change is heavily dependent on what he contributed recently. Thank you Paul. |
elaihau
force-pushed
the
Liang/presentationEcho
branch
from
29dd95a to
2fa3574
Compare
- add the suppport of having `echo` property in the `presentation` object in the task configuration. When `echo` is false, Theia does not print the executed command in the terminal. - resolves #5332 Signed-off-by: Liang Huang <[email protected]>
elaihau
force-pushed
the
Liang/presentationEcho
branch
from
2fa3574 to
998386b
Compare
|
can i have the approval from one you, if the change works as expected :) ? |
|
Thank you Paul ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the suppport of having
echoproperty in thepresentationobject in the task configuration. Whenechois false, Theia does not print the executed command in the terminal.resolves [tasks] display message in terminal when executing a task #5332
Signed-off-by: Liang Huang [email protected]
How to test
Start a task whose configuration does not have the
presentationorpresentation.echodefined. Verify that the executed command should be printed as the first line of the terminal.add
presentation.echo = falseto the task config, rerun the task. Verify that the executed command should NOT be printed in the terminal.Verify the Theia behavior for
shellandprocesstasks.Review checklist