plugin: fix message-service #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7332 Fixes #7491 The following commit fixes the following issues: - it should now be possible for plugins to call the `showMessage` with newlines when using the `modal` MessageOption`. - the `showMessage` should now support displaying the `isCloseAffordance` MessageType option. - fixes the argument type for `MessageItem`. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
bug
akosyakov
requested review from
AlexTugarev,
azatsarynnyy,
elaihau and
RomanNikitenko
elaihau
approved these changes
Apr 15, 2020
|
@AlexTugarev Is it fine with you? |
AlexTugarev
reviewed
Apr 15, 2020
AlexTugarev
approved these changes
Apr 15, 2020
|
@benoitf any breaking changes for che? |
|
@vince-fugnitto are you going to merge it? if we break something we can revert/fix it with a follow-up PR |
Thank you, I'll merge it, it's been in review a while now for others to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #7332
showMessage(ex:showInformationMessage), when using themodalMessageOption.Fixes #7491
showMessageproxy to accept MessageItem type, and ultimately respect theisCloseAffordanceoption. Previously, theclosebutton was always added to the dialog which did not match the behavior present in VS Code.How to test
Message:Available Commands:
Show Message:displays a standard notification
Show Message (New Lines):displays a standard notification message (new lines are unsupported in notifications
Show Modal Message:displays a modal dialog message
Show Modal Message (With Items):displays a modal dialog message with an addition button
Show Modal Message (No Close):displays a modal dialog message without the standard close button
Show Modal Message (No Close With Items):displays a modal dialog message without the standard close button and with additional buttons
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]