Null-check call result rather than function itself #7468
Conversation
There was a problem hiding this comment.
Thank you for your first contribution @amcasey!
Do you mind adding a sign-off to your commit and also making sure to sign the Eclipse Contributor Agreement (ECA).
|
@marechal-p Consider upgrading to typescript@latest 😉 |
I'm not sure as to why it did not fail the build? |
|
@marechal-p I believe we tried to fix that in 3.9 and had to roll it back because it wasn't ready yet (microsoft/TypeScript#37610). You may, nevertheless, find it valuable to switch versions locally and tidy up the other things it finds (I was seeing a lot of strictNullChecks failures). |
|
@vince-fugnitto I think I've completed all the legal stuff |
|
@DanielRosenwasser What's the latest on |
@vince-fugnitto because we don't use latest typescript, see #7468 (comment) |
|
Integration tests are failing. Maybe expectations are wrong. @marechal-p Could you check please? If not I can check later. |
I confirmed, it looks like the ECA has been successfully signed using the validation tool:
|
paul-marechal
force-pushed
the
patch-1
branch
4 times, most recently
from
a7c47af
to
8015507
Compare
|
I just learned that I should not have force-pushed on your own repo... My intention was to fix the test to not trouble you too much, but this went south fast... Now I know. edit: fixed authorship, this was weird. |
|
@marechal-p You can rewrite a commit message in accordance with and we merge your commit:
From https://www.eclipse.org/projects/handbook/#resources-commit |
paul-marechal
force-pushed
the
patch-1
branch
4 times, most recently
from
7f9f2a4
to
37def7c
Compare
From the comment, it seems like this was supposed check for chords, rather than checking for the availability of `isChord`. Co-authored-by: Paul Maréchal <[email protected]> Signed-off-by: Andrew Casey <[email protected]>
|
Ok, now the ECA looks ok, it wasn't like this before. Thanks @akosyakov. |
|
ok, merge |
|
Was waiting for CI, but it was green just earlier indeed. |
|
@marechal-p No worries, GH makes that experience super confusing. In any case, my fork exists just for this change, so there's no harm done. 😄 Thanks, all! |
From the comment, it seems like this was supposed check for chords, rather than checking for the availability of
isChord.I tested only by compiling the TypeScript code, since I don't actually know what Theia is/does.
What it does
How to test
Review checklist
Reminder for reviewers