-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DialogBox] : Improve display for remove folder from workspace #7449
[DialogBox] : Improve display for remove folder from workspace #7449
Conversation
f29b1a3
to
7fbff45
Compare
fca6f89
to
0e01163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.theia-DialogNode{ | ||
line-height: var(--theia-content-line-height); | ||
margin-top: calc(var(--theia-ui-padding)*1.5); | ||
margin-left: calc(var(--theia-ui-padding)*2.5); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor] the styling of css classes can be improved for consistency and readability:
.theia-DialogNode{ | |
line-height: var(--theia-content-line-height); | |
margin-top: calc(var(--theia-ui-padding)*1.5); | |
margin-left: calc(var(--theia-ui-padding)*2.5); | |
} | |
.theia-DialogNode { | |
line-height: var(--theia-content-line-height); | |
margin-top: calc(var(--theia-ui-padding)*1.5); | |
margin-left: calc(var(--theia-ui-padding)*2.5); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your review @vince-fugnitto. I have updated the code with this change in mind.
0e01163
to
32aafd9
Compare
I like the usage of codeicons, more than dots 👍 Hope other know what a dot for the folder means. |
Fixes: eclipse-theia#7443 Improves the display of remove from workspace dialog, adds ellipses before the root-name and gives some margin between different items in the dialogBox for better visual impact. Signed-off-by: Anas Shahid <[email protected]>
32aafd9
to
fd52c3f
Compare
@lmcbout would you like to try it out as well? |
I will test this PR shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, looks fine
Question: In the issue description : " adds ellipses before the root-name", I could not see this in action . Do I need to do something to get it ?
Thankoyou for approving @lmcbout, it was a mistake from my side, I have updated the description of the PR, previously I were to add ellipses to it, but since we have codicons It was best to add a codicon to it. |
What it does
Fixes: #7443
Improves the display of remove from workspace dialog, adds codicon
root-folder
and gives some margin between different items inthe dialogBox for better visual impact.
Also updated the text, and added tooltips on both the
folders
and thetextContent
which now displays the path to the root and the note respectively.Signed-off-by: Anas Shahid [email protected]
How to test
Review checklist
Reminder for reviewers