fixed "applyTo" property in problem matcher for task output

[elaihau]

• With this change, "applyTo" can be used as a property to control if a problem reported on a text document is applied only to open, closed or all documents.

• fixed "applyTo" property in taskConfig.problemMatcher doesn't work properly #7396

Signed-off-by: Liang Huang [email protected]

How to test

1. Open a workspace, define a task that produces warnings / errors, and add a problem mactcher that parses the warnings / errors.
   Mine is

    {
        "type": "npm",
        "script": "lintAAB",
        "problemMatcher": [
            {
                "owner": "eslint97",
                "source": "eslint97",
                "applyTo": "closedDocuments",
                "fileLocation": "absolute",
                "pattern": [
                {
                    "regexp": "^([^\\s].*)$",
                    "kind": "location",
                    "file": 1
                },
                {
                    "regexp": "^\\s+(\\d+):(\\d+)\\s+(error|warning|info)\\s+(.+?)(?:\\s\\s+(.*))?$",
                    "line": 1,
                    "column": 2,
                    "severity": 3,
                    "message": 4,
                    "code": 5,
                    "loop": true
                }
                ]
          }
        ]
    }

and the npm lintAAB is defined in package.json as follows

  "scripts": {
    "lintAAB": "eslint ."
  }

2. Close all docuements, and run the task defined in Step 1. We should be able to see all warnings & errors are displayed in the problems view.

3. Open one document associated with the problem markers added in Step 2. Run the task again. Once the task finishes, markers displayed in Step 2, except for those associated with the opened file, should persist. Markers associated with the opened file should not be displayed.

Please note, in this step, you could possibly still see markers associated with the opened file in the problem view, as other they could be added by other contributors.

4. Close all documents, update applyTo of the problem matcher to "openDocuments". Run the task again. Once the task finishes, markers displayed in Step 2 should not show up, because we only want errors & warnings from opened documents to be reported.

5. When applyTo is "allDocuments", all parsed warnings and errors markers should be displayed in the problems view.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

[akosyakov]

please get rid of caches and use MonacoWorkpace as a single source of the document state

[akosyakov]

code changes looks good, could someone please test it?

[vince-fugnitto]

The changes look good to me 👍
I verified it using a small eslint workspace: https://github.com/vince-fugnitto/eslint-ws,
and can see the generated problem-markers based on the applyTo property present.

[elaihau]

Thank you for your time @vince-fugnitto !