-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit rendering for rating/downloads of an extension if 0 #7380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaiyue0329 the changes look good to me, I verified and did not see any rating/download when the value is 0 (undefined). I also verified that the rating/download is displayed when providing mock data.
@akosyakov I enforced the rating here to be get averageRating(): number | undefined {
return !this.builtin ? this.getData('averageRating') : undefined;
} |
Fixes #7423 This commit fixes the inconsistent `font-family` used when displaying the `download-count` when viewing an extension's information. Signed-off-by: Kaiyue Pan <[email protected]>
@kaiyue0329 it is not correct, if built-in is published to the registry then it should show rating |
Omit the rendering for rating/downloads of an extension in the extension tree if it is equal to 0 Omit the rendering for downloads in extension editor if it is equal to 0 Render the star icons of published extension in extension editor even if rating equals to 0 Signed-off-by: Kaiyue Pan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks great now, thank you!
Merging! Thank you @kaiyue0329 :) |
What it does
Fixes: #7376
Fixes #7423
The pull-request addresses the following:
font-family
for the download count when viewing an extension's informationHow to test
Review checklist
Reminder for reviewers