markers: update format of markers

[vince-fugnitto]

What it does

This pull-request updates the formatting of the markers present in the problems-view to be consistent with the latest updates present from VS Code. Namely, the pull-request updates the markers so that:

1. the severity icon is displayed first.
2. the message is displayed secondly (the message has been bumped since it holds the most important information).
3. the owner/source is then displayed with an attached code if available.
4. the line and column number is then displayed.

Before	After

How to test

1. start the application and open the problems-view.
2. ensure that the view has markers (preferably from different sources), and verify the new formatting.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[elaihau]

I tested on my local with Chrome browser in the following scenarios

• single-root and multi root workspace
• problem markers added by language servers
• problem markers created by customized tasks

worked as expected.

[lmcbout]

Works as expected
Tested with Chrome on Ubuntu 18.04
Note: the icon in front of the file is more visible in VSode than in Theia. For example the "JAVA" icon in Theia is the "JAVA" cup icon, but the dark color on a DARK theme is not as visible as the "JAVA" icon they use in VSCODE . Same for other icons "TS, JS..."

[vince-fugnitto]

Note: the icon in front of the file is more visible in VSode than in Theia. For example the "JAVA" icon in Theia is the "JAVA" cup icon, but the dark color on a DARK theme is not as visible as the "JAVA" icon they use in VSCODE . Same for other icons "TS, JS..."

@lmcbout we are using different default icon themes. If you'd like to test, set the icon theme to seti which is vscode's default theme.

[lmcbout]

@lmcbout we are using different default icon themes. If you'd like to test, set the icon theme to seti which is vscode's default theme.

@vince-fugnitto I think the icons we use are not as visible as the one we use if we set the icons as VSCOde icons. It still works :)

[vince-fugnitto]

I'll merge tomorrow if there are no objections.

[Anasshahidd21]

Works fine on my side as well.