terminal: additional preferences to control xterm options #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
elaihau
reviewed
Mar 8, 2020
You can try the command False
True
|
This commit adds additional `preferences` to control the options passed to `xterm`. The commit includes the following new preferences: - `terminal.integrated.drawBoldTextInBrightColors` - `terminal.integrated.fastScrollSensitivity` - `terminal.integrated.cursorBlinking` - `terminal.integrated.cursorStyle` - `terminal.integrated.cursorWidth` Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/terminal-opts
branch
from
7da401a to
8cc0868
Compare
elaihau
approved these changes
Mar 10, 2020
AndrienkoAleksandr
approved these changes
Mar 10, 2020
|
Thank you for the review @elaihau @AndrienkoAleksandr :) |
|
@vince-fugnitto and @akosyakov, Can you please review and merge #7331? I just improved the message formatting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This commit adds additional
preferencesto control the options passed toxterm.The commit includes the following new preferences:
terminal.integrated.drawBoldTextInBrightColorsterminal.integrated.fastScrollSensitivityterminal.integrated.cursorBlinkingterminal.integrated.cursorStyleterminal.integrated.cursorWidthHow to test
For each test, use a
terminalto verify the changes:terminal.integrated.drawBoldTextInBrightColors
Description
Controls whether to draw bold text in bright colors (notice the configs folder).
True
False
terminal.integrated.fastScrollSensitivity
Description
Controls the fast scrolling speed.
Test Case
Update the value, and verify the changes by scrolling while pressing alt.
The higher the value the faster the scroll.
terminal.integrated.cursorBlinking
Description
Controls whether the cursor blinks.
Test Case
Update the value, and verify the changes (the cursor should blink when set to
true)terminal.integrated.cursorStyle
Description
Controls the style of the terminal cursor.
Block
Bar
Underline
terminal.integrated.cursorWidth
Description
Controls the cursor width when set to 'line'
1
10
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]