-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add integration tests for typescript language #7265
Conversation
@akosyakov I like the changes and the fact we can use this test as a basis for additional tests, and for new languages as well. Should you amend the pull-request, I don't see Travis started? |
@vince-fugnitto It is just a start, I will work more next days. For now this PR only enable awaiting of typescript extension activation and do one dummy test. |
a0e57d0
to
8dfde42
Compare
Weird that travis does not start job for this PR. Do we only build PRs against master? |
8dfde42
to
2d5a19d
Compare
Added more tests for reveal definition for different kind of links (internal, external) and between different widgets (editor and editor preview). It looks good. I will add tests for peek widget tomorrow and then for other language features, hope it will go faster. |
2d5a19d
to
73c990b
Compare
I've added tests for peek definition and will test other features after the lunch. I've done with the VSX Registry integration and will have more time for testing Monaco this week :) |
187886a
to
a14ac9e
Compare
1669e59
to
32b26b2
Compare
c4051f2
to
f51a767
Compare
1c13d2e
to
86c4598
Compare
I've increased timeout. Could you try again? |
I thought my machine was good enough until you asked me... Testing... |
@akosyakov
you are right, found two extra extension in plugins folder After removing them I can not reproduce the problem - all tests are success for me! |
@RomanNikitenko I will keep timeouts, if it slows down ci, i will reduce them. It should not do it for successful builds. |
Currently tests are based on generated src-gen/server.js file. I will change it to generate a custom test file under |
d805417
to
d00c56b
Compare
Are you going to do it within current PR or a separate PR? |
@RomanNikitenko I will rebase and clean up the PR on Monday and then ping you. |
86c4598
to
b4c4882
Compare
@RomanNikitenko tests are changed to use own test file, instead of generated server.ts |
@vince-fugnitto Changed to master and travis is running again, tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run the tests multiple times: they pass successfully and look stable for me!
Signed-off-by: Anton Kosyakov <[email protected]>
b4c4882
to
e70e9e2
Compare
I've updated CHANGELOG and applied all suggestions, going to merge it the build is green. |
What it does
Added integration tests for typescript.
How to test
CI should be green.
Review checklist
Reminder for reviewers