Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: update prerequisites #7256

Merged
merged 1 commit into from
Mar 3, 2020
Merged

documentation: update prerequisites #7256

merged 1 commit into from
Mar 3, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

The following pull-request updates the prerequisites for Linux to include build-essential.

The additional prerequisite was useful in the resolution of the following two issues (but the document was never updated):

How to test

The command was useful to resolve two issues regarding nsfw.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The following commit updates the `prerequisites` for Linux
to include `sudo apt-get install build-essential`.

The change was first described in the following comment #2174 (comment)
but was never included. It was also useful in resolving the issue #7255.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Mar 2, 2020
@vince-fugnitto vince-fugnitto self-assigned this Mar 2, 2020
@vince-fugnitto vince-fugnitto requested a review from lmcbout March 3, 2020 13:15
Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vince-fugnitto We add the build-essential in the documentation, but what about the apps, it is set for some docker images but not all, Do you know why?
If we have it for theia-full-docker, why it is not set for theia-docker or theia-go-docker ?

@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Mar 3, 2020

@vince-fugnitto We add the build-essential in the documentation, but what about the apps, it is set for some docker images but not all, Do you know why?
If we have it for theia-full-docker, why it is not set for theia-docker or theia-go-docker ?

@lmcbout they might be using different base images which already handle build-essential.
Is it blocking this pull-request?

For example, theia-docker is using a base node-alpine image (not debian) so build-essential is not available AFAIK.

Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it blocking this pull-request?

No it is not a blocking issue, just curious why
Looks good
Thanks @vince-fugnitto

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - it's easy to miss this one because most people that use Ubuntu for any development will already have it. We should still document it, of course.

@vince-fugnitto vince-fugnitto merged commit c5569a4 into master Mar 3, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-7255 branch March 3, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants