fix #7240: support loading plugins from symbolic links #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using statSync instead of lstatSync, so isFile or isDirectory will check what the symbolic link refer to but not the link itself. Signed-off-by: tom-shan <[email protected]>
tom-shan
force-pushed
the
symbolic-link
branch
from
ef1bec3 to
3729570
Compare
vince-fugnitto
changed the title
azatsarynnyy
approved these changes
Mar 4, 2020
|
@azatsarynnyy please merge |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #7240
using statSync instead of lstatSync, so isFile or isDirectory will
check what the symbolic link refer to but not the link itself.
How to test
Review checklist
Reminder for reviewers