-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced config dir on the env variable server #7214
Conversation
Note, once the review is over, I am going to drop 8ab1980 from this PR. |
packages/core/src/browser/preferences/preference-configurations.ts
Outdated
Show resolved
Hide resolved
packages/core/src/node/file-uri.ts
Outdated
@@ -54,6 +54,9 @@ export namespace FileUri { | |||
return fsPathFromVsCodeUri + '\\'; | |||
} | |||
} | |||
if (fsPathFromVsCodeUri.startsWith('/file:')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks weird, fsPath should not have scheme already. How can I get URI leading to such case. I think some clients are likely to be bogus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, I reused the previous changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun Could you give a hint? It looks like there is a bug in how some client constructs URI. We should not expect such fs paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove it, if there will be a regression, we will fix it properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akosyakov I added that code as a quick fix. I agree that this is a kludge and we have to find proper solution. The reason I added it was that FileUri.fsPath
, was returning wrong path: /file:/right/path
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorhun it can happen only if a uri passed to FileUri.fsPath
is bogus, the real issue is to figure how one get such bogus URI and fix the producer
packages/plugin-ext/src/main/node/paths/plugin-paths-service.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/node/paths/plugin-paths-service.ts
Outdated
Show resolved
Hide resolved
@kittaakos please squash not your commits in one commit, all of them are fixing issues in the original commit. It is alright since the authorship will be preserved. |
4c2ad5e
to
829839e
Compare
f09eeea
to
17d408f
Compare
Signed-off-by: Mykola Morhun <[email protected]>
607972f
to
c6aefc0
Compare
@akosyakov, I have fixed the build, the tests, and updated the changelog. This PR is ready for review. CC: @benoitf |
Closes #4488. Signed-off-by: Akos Kitta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well and thank you for cleaning up everything!
I've tried to change between .my-theia
and .theia
several times with different set of core and plugin configurations and it worked nicely.
Follow-up of #6650.
What it does
From now on, all configuration (
settings.json
,keymaps.json
, etc) and VS Code extension things (such asglobalStorage
,logs
, andplugin-storage
) goes directly under the configuration folder.Downstream projects can override the default,
.theia
folder name for the configurations. See the example here.What it does not do:
XDG_CACHE_HOME
on Linux andAppData/Local
on Windows, such as workspace storage, extensions and their logs for example) and shareable things (XDG_CONFIG_HOME
on Linux andAppData/Roaming
on WIndows, such assettings.json
,keymaps.json
)How to test
Try the example customization:
tasks.json
should go under.theia-example
),.theia-example
folder under~/
,Review checklist
Reminder for reviewers