[electron] Add ability to create folder in OpenDialog on MacOS

[thegecko]

Signed-off-by: Rob Moran [email protected]

What it does

With reference to the electron docs for the version we use (4.2.12), the file dialog on MacOS doesn't show the 'New Folder' button unless properties.createDirectory has been set.

This is restrictive behaviour when a user needs to use the file dialog to select a folder (properties.openDirectory set to true).

Short of implementing this feature for all other platforms (Windows, Linux, Browser), an easier approach is to set the createDirectory property whenever openDirectory is set on MacOS only.

How to test

Ensure the New Folder button appears when using the openDialog for folders in Electron for MacOS (e.g. open a new workspace).

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I verified the changes and they work well!
In my macOS version, I was getting the new folder icon on master, but with this change I now also get it at the bottom of the dialog:

Master:

Pull-Request:

[thegecko]

In my macOS version, I was getting the new folder icon on master

Older versions of MacOS don't have this icon (see my screenshot), so the new button was badly needed :)

we will require a CQ for the copied code

I disagree, this type is already brought in with the Electron dependency and partially copied here, here and here.
The types are removed at compile time and we already have a CQ for Electron anyway :)

Perhaps I should reword the comment so it doesn't say "copied"?

@marcdumais-work what do you think?

[marcdumais-work]

Perhaps I should reword the comment so it doesn't say "copied"?

+1 ; this case IMHO we're not literally copying code - we're just using an Electron API as per their documentation.

[thegecko]

Comment updated :)

[vince-fugnitto]

I verified the changes on macOS and it worked great :)
I also verified on Linux (Ubuntu) and could not find any regressions.

[thegecko]

Thanks @vince-fugnitto