Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed the metadata scanner to the API. #7134

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

kittaakos
Copy link
Contributor

So extensions developer can subclass the hoster plugin reader.

Signed-off-by: Akos Kitta [email protected]

What it does

Sets the MetadataScanner (scanner) visibility from private to protected.

How to test

Review the change set on GH.

Review checklist

Reminder for reviewers

So extensions developer can subclass the hoster plugin reader.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos requested a review from akosyakov February 11, 2020 16:30
@kittaakos
Copy link
Contributor Author

kittaakos commented Feb 11, 2020

I found another issue with the HosterPluginReader. It implements the BackendApplicationContribution but no-one binds it, so subclasses cannot do much with onStart.

I fix this withing this PR.
Update: I was wrong.

@benoitf
Copy link
Contributor

benoitf commented Feb 11, 2020

would be interesting to know why you need to subclass ?

@kittaakos
Copy link
Contributor Author

kittaakos commented Feb 11, 2020

would be interesting to know why you need to subclass ?

No secret: I am trying to add a schema on the fly to the redhat YAML VS Code extension without creating or modifying the user or workspace settings.

Here: https://github.com/redhat-developer/vscode-yaml/blob/5e339a44a46aceb48ed2aedabc3146ab5db63559/package.json#L85

@benoitf
Copy link
Contributor

benoitf commented Feb 11, 2020

You may use another VS Code extension like

https://github.com/Azure/vscode-kubernetes-tools/blob/16ee367c0943097abee7ad098f3907f9663ef8b8/src/yaml-support/yaml-schema.ts#L30-L36

@akosyakov akosyakov added vscode issues related to VSCode compatibility plug-in system issues related to the plug-in system and removed vscode issues related to VSCode compatibility labels Feb 11, 2020
@kittaakos kittaakos merged commit 3468d00 into master Feb 12, 2020
@kittaakos kittaakos deleted the plugin-reader-api branch February 12, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants