Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Create terminal widget immediately at running task #7108

Closed
wants to merge 1 commit into from

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Feb 8, 2020

What it does

NOT for merge

Please read the description for the PR #6957.

The main idea is to open a terminal immediately when the user asked for running a task.

Actually I don't know where the delay at running task is. As I mentioned we can not create a new terminal immediately (some downstream logic should be executed), so I tried to create a terminal just before run request to the task server.

If it's not enough to solve the issue, I think we could use these changes, but modify a little:

  • detect where is the delay?
  • create a new terminal widget before delay, get widget ID
  • attach to the widget using given ID when a task has started

In my PR I'm trying to simplify the solution and avoid usage of an additional storage for terminal widgets.

@vitaliy-guliy could you take a look - does it make sense? Does it reduce the delay that you described in your PR?

Signed-off-by: Roman Nikitenko [email protected]

@RomanNikitenko
Copy link
Contributor Author

Unfortunately I pressed Create Pull Request button and don't know how to move it to DRAFT, sorry for that...

@RomanNikitenko RomanNikitenko deleted the terminalTask branch May 20, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant