Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust z-index for the search box in the file tree #7089

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Adjust z-index for the search box in the file tree #7089

merged 1 commit into from
Feb 14, 2020

Conversation

kaiyue0329
Copy link
Contributor

@kaiyue0329 kaiyue0329 commented Feb 5, 2020

Fixes #6350

What it does

  • Modify the z-index for the search box in the explorer tree so that it is displayed at the highest level (above the underlying toolbar items)

How to test

  • Focus a node on the explorer tree and start typing to open a search within the tree

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes successfully fix the issue, thank you!

@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer bug bugs found in the application labels Feb 5, 2020
- Modify the z-index (using css variable) for the search box in the explorer tree so that it is displayed at the highest level

Signed-off-by: Kaiyue Pan <[email protected]>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes look good to me 👍

@vince-fugnitto vince-fugnitto merged commit 0bb214c into eclipse-theia:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigator search does not work nicely with several views in the navigator
3 participants