-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keymaps: Keyboard shortcuts text is too small #7060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to rethink the column widths better.
For instance, I do not expect that source
is cutoff as so when I first open the widget with something like the explorer
opened.
Compare this with the implementation present in VS Code:
We should ultimately prioritize:
- that commands and keybindings are displayed entirely when possible
- that the source is displayed properly (should not cutoff the header name)
- that the context (since it is the largest) should be prioritized last
In any case each of these fields can be hovered to display the full content
} | ||
|
||
.kb table .th-keybinding { | ||
width: 20%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update:
- Increased widths for commands and keybindings
- Source is now displayed properly, the way it is done in VSCode
- The context is resized to a smaller size to give more priority to the other two important ones.
Ready for Review.
6a66202
to
e578c40
Compare
Issue ID: eclipse-theia#7051 Fixed the sizing of the font, as well as the spacing of each column just so we can utilize the empty spaces in filling up other column's data and still look clean. Signed-off-by: Muhammad Anas Shahid <[email protected]>
e578c40
to
622bb13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest changes look good to me, thank you!
I don't think others are interested in such a change so I'll go ahead and merge :) |
What it does
Issue ID: #7051
Fixed the sizing of the font, as well as the spacing of each column just so we can utilize the empty spaces in filling up other column's data and still look clean.
Signed-off-by: Muhammad Anas Shahid [email protected]
How to test
Review checklist
Reminder for reviewers