[core] don't let disabled bindings shadow enabled ones #7022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindings contributed from VS Code extensions do currently always shadow
bindings default bindings, no matter they are enabled or not.
What it does
This change checks whether a binding is enabled before including it in any shadowing logic.
How to test
Change the binding of a (usually inactive) keybinding to
Alt+Enter
. (or install the python vscode extension)No open text editor search, search something in an editor and press
Alt+Enter
.It should mark all findings setting multiple cursors.
Review checklist
Reminder for reviewers