FIX Issue 6955 - workbench.action.closeActiveEditor command

[tomer-epstein]

FIX Issue 6955 - workbench.action.closeActiveEditor command doesn't close a WebviewWidget

Signed-off-by: Tomer Epstein [email protected]

Issue: #6955

What it does

This change proposal adds a check whether a given widget is an editor in VS Code sense and can be closed.

How to test

1. git clone https://github.com/tomer-epstein/vscode-close-editor.git
2. cd vscode-close-editor && npm run compile && npm run package
3. copy vscode-close-editor-0.0.1.vsix to plugins folder
4. Click on a editor title (right) , choose 'VSCode Close Active Editor' / 'VSCode Close Other Editors' or 'VSCode Close All Editors'.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[amiramw]

@tomer-epstein

1. When i test without your fixes it seems that closeAllEditors, closeEditorsToTheRight, closeEditorsToTheLeft and closeOtherEditors work fine with webviews without your fix. Am I missing something?
2. What is the expected behavior of closeEditorsInGroup and closeEditorsInOtherGroups?

[akosyakov]

@amiramw could you finish the review please? i will comment if see something

[tomer-epstein]

@tomer-epstein

1. When i test without your fixes it seems that closeAllEditors, closeEditorsToTheRight, closeEditorsToTheLeft and closeOtherEditors work fine with webviews without your fix. Am I missing something?
2. What is the expected behavior of closeEditorsInGroup and closeEditorsInOtherGroups?

@amiramw where did you test? on which env? did you test via vscode-close-editor vsix?

• editors in group - https://code.visualstudio.com/docs/getstarted/userinterface#_editor-groups

[amiramw]

Code LGTM and tested successfully before and after the fix.

I did see a difference in close editors in group behavior. In vs code it closes all editors in group while here we close all editors except current one. @tomer-epstein please open a separate issue for that as I don't think it should block this PR.

[tomer-epstein]

issue has been opened : #6997

[amiramw]

@tomer-epstein can you fix the cut off commit message?