Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos present in '@theia/core' #6961

Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix typos present in '@theia/core' #6961

merged 1 commit into from
Jan 27, 2020

Conversation

justin8502
Copy link
Contributor

Issue: #6899

What it does

  • fixes various typos throughout the codebase.

Review checklist

Reminder for reviewers

@justin8502 justin8502 changed the title fix typos present in '@theia/core' #6912 fix typos present in '@theia/core' Jan 24, 2020
@justin8502
Copy link
Contributor Author

Still figuring out how merges work. Reset fork to point to upstream, then created a branch from fork with changes for this issue (previously i was just pushing to master).

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! 👍

Thank you for your contribution, I understand that working off forks may be confusing at first but there should be some good articles about successfully contributing to open-source using forks :)

For example, the following article describes the usual steps when working in open-source with forks in an easy to convey matter.

@vince-fugnitto
Copy link
Member

The branch does look to be in a weird state however as it cannot be rebased safely:

Screen Shot 2020-01-24 at 11 22 38 AM

Perhaps follow the general guide described in the article I mentioned.

@vince-fugnitto vince-fugnitto self-requested a review January 24, 2020 16:22
@justin8502
Copy link
Contributor Author

justin8502 commented Jan 25, 2020

Looking into it.

@justin8502 justin8502 closed this Jan 25, 2020
- CHANGELOG now properly references pull request

Signed-off-by: Justin Ang <[email protected]>
@justin8502 justin8502 reopened this Jan 25, 2020
@akosyakov akosyakov added the core issues related to the core of the application label Jan 27, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! 👍

@vince-fugnitto vince-fugnitto merged commit e1d08d0 into eclipse-theia:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants