Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align vscode types implementation #6903

Closed

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jan 17, 2020

What it does

TODO:

  • a CQ for copied code

How to test

Review checklist

Reminder for reviewers

@akosyakov akosyakov added the vscode issues related to VSCode compatibility label Jan 17, 2020
@akosyakov akosyakov force-pushed the akosyakov/inconsistent-vscode-workspace-6895 branch from a4e0e32 to d3d28af Compare January 20, 2020 03:43
@akosyakov
Copy link
Member Author

For some reason typescript does not erase @theia/plugin with latest types :( We need ts 3.8 to import only types, will need to wait a bit.

@mbenz89
Copy link

mbenz89 commented Jan 28, 2020

I'm running into issues with the sarif viewer vscode plugin because the extension cannot find the internal vsvode types in @types/vscode (especially the Range and Position types). Essentially I got the same problem as #6895 . It seems that this PR could fix this issue by providing compatible types.

For some reason typescript does not erase @theia/plugin with latest types

I'm new to typescript. Could you clarify what that means?
Do you see any way to get this pr working with the current release or is there no other way than waiting for ts 3.8 (planned for 18.2.20)?

@JonasHelming JonasHelming added the decision_needed issues that require decisions on ways forward (ex: if they should be updated or closed) label Feb 16, 2022
@tsmaeder
Copy link
Contributor

Since this is still a draft PR and @akosyakov is unlikely to work on it, I'm closing this.

@tsmaeder tsmaeder closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision_needed issues that require decisions on ways forward (ex: if they should be updated or closed) vscode issues related to VSCode compatibility
Projects
None yet
4 participants