Fix add missing await on workspace edits file create

[amiramw]

Signed-off-by: Amiram Wingarten [email protected]

What it does

Fixes a missing await for file creation done as part of workspace edits.

How to test

VS Code extension containing code like the below will create an empty file as the promise does not wait for the file to be created.

let we = new vscode.WorkspaceEdit();
let pathUri = vscode.Uri.file(path);
we.createFile(pathUri);
vscode.workspace.applyEdit(we).then(function() {
 writeFileSync(tasksPathUri.fsPath, "some content");
});

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@amiramw I tried to create a VS Code extension which performs the same behavior as you described in the pull request, however the extension worked correctly in master. Perhaps you can share your own extension so I can more easily test?

My extension is the following:
https://github.com/vince-fugnitto/theia-test-ext/releases/download/1.0.0/test-ext-0.0.1.vsix

[amiramw]

@vince-fugnitto
The issue occurs when the creation is to a file with its parent folder, both are new.
The problem reproduces when I change your path calculation to:

vscode.Uri.file(workspacePath.uri.fsPath + '/newdir/test.txt');

[vince-fugnitto]

@amiramw I updated my example extension and noticed the bug on master.
Thanks to your update I see the correct behavior, the folder and file are created with the correct content 👍

[vince-fugnitto]

@amiramw do you need help with the merge?

[amiramw]

yes. I don't have merge permissions.

[akosyakov]

@marcdumais-work Do you know why @amiramw don't have permissions? Here is a committer.

[marcdumais-work]

@marcdumais-work Do you know why @amiramw don't have permissions? Here is a committer.

I do not see him as part of the org's members. When the org was crated, each committer should have received an invite, that one must accept before being granted effective write permission.

But we had at least one case where a committer was not "synced" correctly and so left out. Maybe this is another instance of this? I would suggest opening a bugzilla under "community" -> "github" and ask to check why @amiramw is not part of the membership.

[amiramw]

@marcdumais-work should I open it? where exactly?

[marcdumais-work]

@marcdumais-work should I open it? where exactly?

Yes, that would be the most efficient since you'll need to at least validate it works in the end.

Start here and select "github" as component.

[amiramw]

Apperently I didn't have the correct github id in my eclipse profile. Seems fine now.

Thanks @marcdumais-work @akosyakov !