[statusbar] add misc statusbar tooltips

[vince-fugnitto]

What it does

• added statusbar tooltip for select language mode
• added statusbar tooltip for select encoding
• added statusbar tooltip for select indentation
• added statusbar tooltip for select end of line sequence
• added statusbar tooltip for go to line (clicking the statusbar item now triggers the go to line command)`

How to test

1. verify that each tooltip described above correctly displays
2. verify that the go to line statusbar item now triggers the go to line command

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Vincent Fugnitto [email protected]

[lmcbout]

Looks good
Comment: When I start in electron and there is already a file in the editor(settings.json) the status bar does not show the options to test, I need to open a new file or close + re-open a file to see the status bar options.

If possible, when the browser is full screen, The tooltip overlaps the status bar text, could it be possible to put the tooltip above the status bar in this case
Look at the code OK
Tested on Ubuntu only

[vince-fugnitto]

Comment: When I start in electron and there is already a file in the editor (settings.json) the status bar does not show the options to test, I need to open a new file or close + re-open a file to see the status bar options.

It worked correctly for me, I see all available statusbar items even if an editor is currently opened on startup. Which statusbar item did you not see?

If possible, when the browser is full screen, The tooltip overlaps the status bar text, could it be possible to put the tooltip above the status bar in this case

The tooltip is controlled by the browser and operating system.
I don't think there is a way using the default title attribute to be able to control the behavior easily.
For reference, you can also try in VS Code.

[lmcbout]

Which statusbar item did you not see?

All of the items on the right side

[vince-fugnitto]

Which statusbar item did you not see?

All of the items on the right side

As we verified together, the contributed contributed statusbar items in question are only added when the editor itself has selection. If an editor does not have selection on startup, the statusbar items are not present which in this case is the observed behavior. Perhaps we can be smarter about when these items are created but I feel as though it is out of the scope of this particular pull request.

[elaihau]

I tested it in Gitpod. Looks good. Thank you !

[elaihau]

BTW, I don't see tooltip text for the status bar button for the problems & warinings - not sure how difficult it is to add the tooltip for it.

[vince-fugnitto]

BTW, I don't see tooltip text for the status bar button for the problems & warinings - not sure how difficult it is to add the tooltip for it.

Thanks! I actually covered it later in #6771