[messages] add tooltip to notification statusbar item #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
notifications
AlexTugarev
reviewed
Dec 17, 2019
| if (this.manager.centerVisible) { | ||
| return 'Hide Notifications'; | ||
| } | ||
| return `${count ? `${count} Notifications` : 'No Notifications'}`; |
There was a problem hiding this comment.
nit: @vince-fugnitto could you make it singular for a single item, please?
There was a problem hiding this comment.
Sure :) I updated the pull request
- adds a tooltip to the `notification` statusbar item.
- displays `Hide Notifications` when the notification center is expanded.
- displays `No Notifications` when the notification center is collapsed and no notifications are present.
- displays `{count} Notifications` when the notification center is collapsed and notifications are present.
Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/notification-statusbar-tooltip
branch
from
cb6ee83 to
71bacea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Minor enhancement adding a tooltip to the Notification statusbar item:
Hide Notificationswhen the notification center is expanded.No Notificationswhen the notification center is collapsed and no notifications are present.{count} Notificationswhen the notification center is collapsed and notifications are present.How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]