Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[task] fix circular dependencies from 'task' extension #6756

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes the circular dependencies present from the @theia/task extension:

  • Remove the circular dependency.
  • Export the moved classes from the original file not to break consumers.
Before After
image image

How to test

  • Verify that CI successfully passes (build & tests of the @theia/task extension).
  • Verify that clicking the Configure icon (cog) still works correctly when selecting Run Tasks....

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

- fixed the circular dependencies from the `@theia/task` extension.

Signed-off-by: Vincent Fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added tasks issues related to the task system quality issues related to code and application quality labels Dec 16, 2019
@vince-fugnitto vince-fugnitto self-assigned this Dec 16, 2019
@vince-fugnitto
Copy link
Member Author

I don't have a strong opinion on this.
If others find that this is not a real problem or unnecessary then I do not object if it is closed :)

@elaihau
Copy link
Contributor

elaihau commented Dec 16, 2019

I have no issues with this change. but having Roman's opinion is preferable, as he was the person who did the task action provider.

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that Configure icon (cog) still works correctly.

@vince-fugnitto
thank you for fix!

@vince-fugnitto
Copy link
Member Author

Thank you @elaihau @RomanNikitenko !

@vince-fugnitto vince-fugnitto merged commit 4c4a1f2 into master Dec 17, 2019
@vince-fugnitto vince-fugnitto deleted the vf/task-circular branch December 17, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants