search detected tasks by scope #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is created as a draft PR, because the solution I proposed here includes a breaking change, and I am not sure if there is a better way to fix the bug. Also, I suspect this change would break CHE badly. Thank you in advance for the feedback ! |
|
@elaihau |
|
Thank you Roman, I will do more testing later today and finalize the change. |
elaihau
force-pushed
the
Liang/same_label_detected_task
branch
from
f42682d to
eaeb26a
Compare
This pull request adds the support of detected tasks that have - same label, and - different scopes in a multi-root workspace. This change fixes #6715. Signed-off-by: Liang Huang <[email protected]>
elaihau
force-pushed
the
Liang/same_label_detected_task
branch
from
eaeb26a to
eea3332
Compare
|
Ready for review. |
vince-fugnitto
added
multi-root
lmcbout
approved these changes
Dec 10, 2019
RomanNikitenko
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Tested in a multi-root workspace for tsc tasks: the bug is fixed for me!
che tasks work well.
@elaihau thank you!
vince-fugnitto
approved these changes
Dec 10, 2019
|
Thank you for your reviews ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the support of detected tasks that have
in a multi-root workspace. This change fixes Theia could possibly start wrong detected task in a multi root workspace #6715.
Signed-off-by: Liang Huang [email protected]
How to test
Prepare a multi root workspace. Make sure two or more root folders contribute detected tasks that have the same name. In the GIF below, both of my root folders (i.e.,
test-dirandtest-resource_Bhavenpm: myWatchdefined in theirpackage.jsonfiles)Run
npm: myWatchfrom root foldertest-dir.Check which
npm: myWatchwas started. In the GIF below, I startednpm: myWatchintest-dir, and the task history and populated messages showed that the task was started in the right root folder.Review checklist
Reminder for reviewers