-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for VsCode Vim extension #6687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
added
keybindings
issues related to keybindings
vscode
issues related to VSCode compatibility
labels
Dec 4, 2019
45 tasks
akosyakov
reviewed
Dec 4, 2019
akosyakov
reviewed
Dec 4, 2019
packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts
Outdated
Show resolved
Hide resolved
akosyakov
reviewed
Dec 6, 2019
vinokurig
force-pushed
the
che-9244_vim
branch
from
December 9, 2019 08:16
3d8e0e2
to
c074eac
Compare
akosyakov
reviewed
Dec 9, 2019
Signed-off-by: Igor Vinokur <[email protected]>
vinokurig
force-pushed
the
che-9244_vim
branch
from
December 9, 2019 10:51
c074eac
to
a53c6e5
Compare
akosyakov
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vim extension works without errors for me, thank you! @vinokurig
It feels slower than usual typing. Probably because of client-server turnaround for each character or maybe it is the same in VS Code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes and adaptations that allow to use VsCode Vim extension
What it does
trigger
transit command.default:type
.How to test
Apply VsCode Vim extension
Available commands:
cursorMove
built-in command)cursorMove
built-in command)cursorMove
built-in command)editor.action.reindentselectedlines
built-in command)-
+
>
Review checklist
Reminder for reviewers