break DI cycle between LabelProvider and its contributions #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butions See #5884 (comment) Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov
requested review from
westbury,
svenefftinge,
AlexTugarev,
kittaakos and
vince-fugnitto
and removed request for
westbury
akosyakov
commented
Nov 22, 2019
| @@ -98,14 +99,20 @@ export class DefaultUriLabelProviderContribution implements LabelProviderContrib | |||
| } | |||
|
|
|||
| @injectable() | |||
| export class LabelProvider { | |||
| export class LabelProvider implements FrontendApplicationContribution { | |||
There was a problem hiding this comment.
I could extract another class to avoid adding initialize as public API to LabelProvider, something like LabelProviderContributions. LabelProvider will use it to find contributions listen to its changes. Should I?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See #5884 (comment)
LabelProvider tries to create contributions during instantiation, but some contributions need
LabelProvider, so it goes forever.The cycle is broken by moving creation of contributions to the frontend application initialization, so after an instance of
LabelProvideris created.How to test
Build, start the app and check that the browser console does not
Review checklist
Reminder for reviewers