Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search-in-workspace] update resizing css for result list #6576

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #6569

  • fixes issue where long search strings are not properly displayed
    in the search-in-workspace result list.
  • removed unnecessary inline-block to instead use inherited display: flex.

How to test

  1. search for a very long string, the result list should display properly as compared to master.

Example:

a

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

Fixes #6569

- fixes issue where long search strings are not properly displayed
in the `search-in-workspace` result list.
- removed unnecessary `inline-block` to instead use inherited `display: flex`.

Signed-off-by: Vincent Fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added bug bugs found in the application search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience labels Nov 18, 2019
@vince-fugnitto vince-fugnitto self-assigned this Nov 18, 2019
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly for me

@vince-fugnitto
Copy link
Member Author

I'll give it some time to see if any others would like to try it out as well :)

Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a few strings with Chrome on Ubuntu

Works fine Thanks @vince-fugnitto

@vince-fugnitto
Copy link
Member Author

Thank you @mmorhun @lmcbout !

@vince-fugnitto vince-fugnitto merged commit c674483 into master Nov 20, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-6569 branch November 20, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application search in workspace issues related to the search-in-workspace ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Found text match in Search panel is not displayed at all if its length doesn't fit panel size
3 participants